fix: abstract out cpio operations to helper function#1356
Merged
Conversation
egibs
approved these changes
Feb 5, 2026
This lets us defer the close operation to the end of the helper function and not try to do the closes in all the early exit operations of the loop. v2: drop cyclometric complexity lint silencing comment Signed-off-by: Steve Beattie <steve.beattie@chainguard.dev>
stevebeattie
force-pushed
the
fix-rpm-close
branch
from
fcb571c to
9cfaf8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us defer the close operation to the end of the helper function and not try to do the closes in all the early exit operations of the loop.